Re: [hackers] [sbase][PATCH] Add test framework with a test for tty(1)

From: Mattias Andrée <>
Date: Sun, 8 Jul 2018 00:12:08 +0200

On Sat, 7 Jul 2018 22:55:28 +0100
Dimitris Papastamos <> wrote:

> This is too intrusive, what's wrong with using a shell script to test
> the commands?
> The test framework is more complicated than most sbase commands.
> It would have been nice to discuss this in advance before writing a
> 1000 line patch that might not get merged.

Writing all tests in shell isn't the best idea I think.
This frameworks makes it easy to write test and it will
tell you everything you need to know to figure out what
failed. I believe that in the need this will reduce the
amount of test code. There are things that are difficult
to do in shell: for example create a terminal which is
need to test tty(1). Look for example at the tests in, they aren't
that nice, and they even require bash(1), it would be
even worse with portable sh(1).

Received on Sun Jul 08 2018 - 00:12:08 CEST

This archive was generated by hypermail 2.3.0 : Sun Jul 08 2018 - 00:12:38 CEST