Re: [hackers] [st][PATCH] Follow text color only if exists

From: Ivan Tham <pickfire_AT_riseup.net>
Date: Sun, 15 Jul 2018 18:26:13 +0800

Yes, I was using fish shell on st. When when you insert a character, it
will have syntax highlighting and change the color then it fails there.

Maybe the color is true color?

On Sat, Jul 14, 2018 at 11:21:46PM +0200, Jules Maselbas wrote:
>Hi,
>
>> Fix crash when text color is not set and is out of bound.
>> ---
>> x.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/x.c b/x.c
>> index b51821d..4b7ffe6 100644
>> --- a/x.c
>> +++ b/x.c
>> _AT_@ -1425,7 +1425,7 @@ xdrawcursor(int cx, int cy, Glyph g, int ox, int oy, Glyph
>> og)
>>
>> if (g.mode & ATTR_BOLD && BETWEEN(g.fg, 0, 7))
>> drawcol = dc.col[g.fg + 8];
>> - else
>> + else if (g.fg < LEN(dc.col))
>Can you explain how this can happen, I thought that g.fg cannot be above 255.
>
>> drawcol = dc.col[g.fg];
>> }
>>
>> --
>> 2.18.0

-- 
Do what you like, like what you do.  -- Pickfire
Received on Sun Jul 15 2018 - 12:26:13 CEST

This archive was generated by hypermail 2.3.0 : Sun Jul 15 2018 - 12:36:22 CEST