Re: [hackers] [sbase][PATCH v2] Add tests for some utilities

From: Roberto E. Vargas Caballero <k0ga_AT_shike2.com>
Date: Fri, 3 Aug 2018 07:37:05 +0100

Hi,

On Wed, Aug 01, 2018 at 09:16:26PM +0200, Silvan Jegen wrote:
> > * `echo` is unportable and `printf` should be used instead.
>
> Didn't know that echo was not portable. Thought it was just a builtin
> that should work the same everywhere. It's probably the flags that are
> the issue...

echo is portable, bad usage of echo is not portable. Use printf
when you want complex numeric conversions or escape sequences,
otherwise use echo.

> If we go with option 1) I would like to wait to see which C functionality
> we would end up needing in the end. Looking at the C code I would postpone
> until after that decision has been made.

You can do whatever you want, but you should ask to the maintainers first,
and I am pretty sure they don't agree with the kind of tests that you want to
implement, so don't lose your time and try to have a conversation first with
the maintainers. Everything else that is not agreed with them is not going
to be applied.

Regards,
Received on Fri Aug 03 2018 - 08:37:05 CEST