Re: [hackers][sbase][PATCH] Fix build errors on some ARM64 Linux systems

From: David Phillips <david_AT_sighup.nz>
Date: Tue, 28 Aug 2018 10:15:05 +1200

On Mon, Aug 27, 2018 at 09:21:33PM +0200, Hiltjo Posthuma wrote:
> On Mon, Aug 27, 2018 at 09:37:24PM +0300, Platon Ryzhikov wrote:
> > These changes are required on Arch Linux ARM to build sbase. This does not affect x86 build.
> > ---
> > ls.c | 1 +
> > tar.c | 1 +
> > 2 files changed, 2 insertions(+)
> >
> > diff --git a/ls.c b/ls.c
> > index b716aba..9e79fcb 100644
> > --- a/ls.c
> > +++ b/ls.c
> > _AT_@ -1,6 +1,7 @@
> > /* See LICENSE file for copyright and license details. */
> > #include <sys/stat.h>
> > #include <sys/types.h>
> > +#include <sys/sysmacros.h>
> >
> > #include <dirent.h>
> > #include <grp.h>
> > diff --git a/tar.c b/tar.c
> > index a6ead2e..9359bfd 100644
> > --- a/tar.c
> > +++ b/tar.c
> > _AT_@ -1,6 +1,7 @@
> > /* See LICENSE file for copyright and license details. */
> > #include <sys/stat.h>
> > #include <sys/time.h>
> > +#include <sys/sysmacros.h>
> >
> > #include <errno.h>
> > #include <fcntl.h>
> > --
> > 2.18.0
> >
>
> As reported before this is wrong and probably Linux and glibc-specific.
>
> Also sort the include names.
>
> --
> Kind regards,
> Hiltjo

How does my updated patch from Jul 8 on the previous report for this
bug look?


Thanks,
David
Received on Tue Aug 28 2018 - 00:15:05 CEST