Re: [hackers] [PATCH][sbase] find: fix flag setting

From: Michael Forney <mforney_AT_mforney.org>
Date: Mon, 24 Sep 2018 13:02:36 -0700

On 7/8/18, Silvan Jegen <s.jegen_AT_gmail.com> wrote:
> Heyho
>
> Found this when running smatch on sbase.

The current code is correct. -H should turn on gflags.h, and turn off
gflags.l. POSIX says each flag should override the other. I agree that
the current code is a little confusing.

It would probably be clearer as

case 'H': gflags.h = 1; gflags.l = 0; break;
case 'L': gflags.h = 0; gflags.l = 1; break;
Received on Mon Sep 24 2018 - 22:02:36 CEST