Re: [hackers] [st][PATCH] Makefile: fix dependencies on config.h

From: Hiltjo Posthuma <hiltjo_AT_codemadness.org>
Date: Mon, 31 Dec 2018 10:55:44 +0100

On Sun, Dec 30, 2018 at 11:21:58PM +0100, Younes Khoudli wrote:
> st.o doesn't depend on config.h, x.o does.
>
> Signed-off-by: Younes Khoudli <khoyobegenn_AT_gmail.com>
> ---
> Makefile | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/Makefile b/Makefile
> index 0b3cecd..0730757 100644
> --- a/Makefile
> +++ b/Makefile
> _AT_@ -21,8 +21,8 @@ config.h:
> .c.o:
> $(CC) $(STCFLAGS) -c $<
>
> -st.o: config.h st.h win.h
> -x.o: arg.h st.h win.h
> +st.o: st.h win.h
> +x.o: arg.h config.h st.h win.h
>
> $(OBJ): config.h config.mk
>
> --
> 2.20.1
>
>

st.o depends on config.h, for example for worddelimiters.

Add a depend for both st.o and x.o on config.h seems better, no?

-- 
Kind regards,
Hiltjo
Received on Mon Dec 31 2018 - 10:55:44 CET

This archive was generated by hypermail 2.3.0 : Mon Dec 31 2018 - 11:00:23 CET