Re: [hackers] [st][PATCH] Set the path of pkg-config in a variable instead of hardcoding it

From: Paride Legovini <pl_AT_ninthfloor.org>
Date: Fri, 4 Jan 2019 13:41:33 +0100

Hiltjo Posthuma wrote on 04/01/2019:
> On Fri, Jan 04, 2019 at 09:48:37AM +0100, Paride Legovini wrote:
>> In this way the path of pkg-config can be overridden from the command
>> line. This is useful for example when cross-compiling.
>
> But you can already override INCS and LIBS.

Hello Hiltjo, thanks for your feedback.

You are right, the same result can be obtained by overriding INCS and
LIBS, however just overriding PKG_CONFIG is easier and probably more
robust: the override will stay the same even if in future releases the
default INCS and LIBS are changed. I don't think the patch adds any
significant complexity.

To be concrete I'll explain my use case. I am the new maintainer of st
in Debian, and the Debian helper scripts automatically (try to) override
PKG_CONFIG when cross-compiling. If the patch is merged then the package
will cross-compile without changing anything. I know you don't target
Debian specifically, this is just to show a practical example.

[Please keep me in Cc:, I am subscribed to hackers_AT_ in nomail mode.]

Paride
Received on Fri Jan 04 2019 - 13:41:33 CET