Re: [hackers] [st][PATCH] Let the user specify CPPFLAGS

From: Laslo Hunhold <dev_AT_frign.de>
Date: Thu, 10 Jan 2019 14:17:05 +0100

On Thu, 10 Jan 2019 13:36:09 +0100
Paride Legovini <pl_AT_ninthfloor.org> wrote:

Dear Paride,

> This complements the work done in d4928ed, allowing the user to
> specify the preprocessor flags with the CPPFLAGS environment
> variable. This is useful for example to specify preprocessor macros
> with -D.
>
> CFLAGS could be used instead, but CPPFLAGS is more correct and is
> expected to be honored in some cases. For example, the helper scripts
> to build Debian packages make use of CPPFLAGS, but the variable is
> currently being ignored unless manually appended to CFLAGS.

I would generally question this notion. POSIX specifies the -e flag
for make(1)[0]:

        Cause environment variables, including those with null
        values, to override macro assignments within makefiles.

Doesn't this solve the problem more elegantly?

With best regards

Laslo Hunhold

[0]:http://pubs.opengroup.org/onlinepubs/9699919799/utilities/make.html

-- 
Laslo Hunhold <dev_AT_frign.de>

Received on Thu Jan 10 2019 - 14:17:05 CET

This archive was generated by hypermail 2.3.0 : Thu Jan 10 2019 - 14:24:20 CET