Re: [hackers] [st][PATCH 00/24] odg patches - fix warnings/errors, plug leaks, tidying up

From: Quentin Rameau <quinq_AT_fifth.space>
Date: Tue, 22 Jan 2019 09:46:57 +0100

Hi Oliver,

> > These patches fix all errors and warnings I found when building with lots of
> > compiler warning flags enabled, and running tools like cppcheck and valgrind.
> > There's lots of type and const correctness fixes, conflicting variable names,
> > a couple of memory leaks, and stylistic stuff like reducing variable scope.
> > Also avoid linking with libm and make building on OpenBSD a bit more
> > straightforward.
>
> First point, why do you think we care about what your linter says? If it
> gives false positives send patches to the developers of your linter.

Thanks for your interest, but yeah, obviously you didn't take a look at
the project before diving head on into bikeshedding patches (mostly).

But that's ok, everybody has to learn, you are. This doesn't mean you
have to stop there, just get back on it and avoid those kind of
“patching what compiler warnings say” while taking in mind what the
project you're patching is about and how it's written (and more
precisely why).
Received on Tue Jan 22 2019 - 09:46:57 CET