Re: [hackers] [st][PATCH] st-disable-bold-italic-fonts-0.8.2

From: Ryan <alrayyes_AT_gmail.com>
Date: Tue, 2 Apr 2019 08:15:21 +0200

Feel free to change it. All I did with the patch is change the previous
version so it works with 6.2.

On Tue, 2 Apr 2019, 08:13 Eric Pruitt, <eric.pruitt_AT_gmail.com> wrote:

> On Sat, Mar 30, 2019 at 02:31:56PM +0100, Ryan Kes wrote:
> > +int disableroman = 0;
> > [...]
> > + if (!disableitalic)
> > + FcPatternAddInteger(pattern, FC_SLANT, FC_SLANT_ITALIC);
> > + if (!disableroman)
> > + FcPatternAddInteger(pattern, FC_SLANT, FC_SLANT_ROMAN);
>
> I don't think you need separate conditions/booleans for FC_SLANT_ROMAN
> because roman is the opposite of italic, so the code should read
> something like this:
>
> FcPatternAddInteger(pattern, FC_SLANT, disableitalic ? FC_SLANT_ROMAN
> : FC_SLANT_ITALIC);
>
> Or maybe I don't understand how Fontconfig works.
>
> Eric
>
>
Received on Tue Apr 02 2019 - 08:15:21 CEST