Re: [hackers] [PATCH 1/2] Use *at functions with appropriate flags instead of lstat/lchown

From: Laslo Hunhold <>
Date: Sun, 29 Dec 2019 12:29:00 +0100

On Sat, 28 Dec 2019 16:06:20 -0800
Michael Forney <> wrote:

Dear Michael,

> There is a slight performance benefit, but it is pretty negligible due
> to system call overhead. I tested du(1) on an extracted linux-5.4.6
> source tree and saw an improvement of about 4-5% on my system
> (comparing average of 20 runs).
> I think the main benefit is the decreased stack usage and the
> possibility to refactor other tools like cp to share the recurse code
> (since now the base name is passed by itself).

this is really cool! 4-5% is definitely quite a bit and I would not
call it negligible.
Keep up the great work!

With best regards


Received on Sun Dec 29 2019 - 12:29:00 CET

This archive was generated by hypermail 2.3.0 : Sun Dec 29 2019 - 12:36:27 CET