Re: [hackers] [st][PATCH] Increase XmbLookupString buffer

From: Hiltjo Posthuma <hiltjo_AT_codemadness.org>
Date: Sat, 18 Jan 2020 14:24:32 +0100

On Sat, Jan 18, 2020 at 03:52:25PM +0800, Ivan Tham wrote:
> Current buffer is too short to input medium to long sentences from IME.
> Input with longer text will show the wrong input, taking 64 instead of
> 32 bytes should be enough for most of the cases. Broken cases before,
>
> Chinese (taken from song 也可以)
> 可不可以轻轻的松开自己
>
> Japanese (taken from bootleggers rom quote)
> あなたは家のように感じる
> ---
> x.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/x.c b/x.c
> index bc3ad5a..e000894 100644
> --- a/x.c
> +++ b/x.c
> _AT_@ -1743,7 +1743,7 @@ kpress(XEvent *ev)
> {
> XKeyEvent *e = &ev->xkey;
> KeySym ksym;
> - char buf[32], *customkey;
> + char buf[64], *customkey;
> int len;
> Rune c;
> Status status;
> --
> 2.25.0
>
>

OK sure, thanks, pushed.

-- 
Kind regards,
Hiltjo
Received on Sat Jan 18 2020 - 14:24:32 CET

This archive was generated by hypermail 2.3.0 : Sat Jan 18 2020 - 14:36:27 CET