Re: [hackers] [st][PATCH] Rearrange x run with fast exit

From: Ivan Tham <pickfire_AT_riseup.net>
Date: Thu, 19 Mar 2020 09:03:56 +0800

>> On Wed, Mar 18, 2020 at 02:10:36PM +0100, Quentin Rameau wrote:
>> >> Quickly swap out of loop to reduce indentation needed.
>> >> Reuse deltatime variable to reuse calculation.
>> >
>> >Don't be afraid to separate unrelated modifications into separate
>> >commits!
>> >
>> On Wed, Mar 18, 2020 at 09:41:14PM +0100, Quentin Rameau wrote:
>> I separate unrelated modifications into unrelated commits but this is
>> still related, I think it also belongs under reorderings.
>
>That was the polite way of saying “They're unrelated, separate them in
>two commits”, apparently polite messages don't convey the meaning.

Ah, I thought it was just telling me that it is possible to separate
unrelated modifications but I already know that. I will send a patch.

Thanks.
Received on Thu Mar 19 2020 - 02:03:56 CET