Re: [hackers] [quark][PATCH] Fix overflow when calling strtonum in parse_range

From: Laslo Hunhold <dev_AT_frign.de>
Date: Sun, 1 Nov 2020 01:50:55 +0100

On Sun, 1 Nov 2020 01:15:32 +0100
José Miguel Sánchez García <soy.jmi2k_AT_gmail.com> wrote:

Dear José,

> Good point! It could be the case that SIZE_MAX is smaller than
> LLONG_MAX. Honestly I don't know, but I would do what you are
> proposing just to be sure: it is the safest option, and maybe the
> compiler will take care of replacing the correct value at compile
> time. Way better than leaving another bug lingering until someone
> else finds it again.

we should be safe at that point and I have committed the MIN-solution
in commit 7d26fc695. Thanks for your report!

With best regards

Laslo
Received on Sun Nov 01 2020 - 01:50:55 CET