Re: [hackers] [tabbed][PATCH] Remove quotes around variables in Makefile

From: Hiltjo Posthuma <hiltjo_AT_codemadness.org>
Date: Fri, 2 Apr 2021 11:03:05 +0200

On Thu, Apr 01, 2021 at 08:53:35PM -0400, Sebastian LaVine wrote:
> Previously, if you had changed your PREFIX in config.mk to something
> like ~/.local, then instead of installing to /home/user/.local, a
> directory called '~' would be created in the project directory. Commands
> are also performed without quotes in the Makefiles of other suckless
> projects, like st or dwm.
> ---
> Makefile | 24 ++++++++++++------------
> 1 file changed, 12 insertions(+), 12 deletions(-)
>
> diff --git a/Makefile b/Makefile
> index 1b95d15..acc3246 100644
> --- a/Makefile
> +++ b/Makefile
> _AT_@ -44,22 +44,22 @@ dist: clean
>
> install: all
> _AT_echo installing executable files to ${DESTDIR}${PREFIX}/bin
> - _AT_mkdir -p "${DESTDIR}${PREFIX}/bin"
> - _AT_cp -f ${BIN} "${DESTDIR}${PREFIX}/bin"
> - _AT_chmod 755 "${DESTDIR}${PREFIX}/bin/tabbed"
> + _AT_mkdir -p ${DESTDIR}${PREFIX}/bin
> + _AT_cp -f ${BIN} ${DESTDIR}${PREFIX}/bin
> + _AT_chmod 755 ${DESTDIR}${PREFIX}/bin/tabbed
> _AT_echo installing manual pages to ${DESTDIR}${MANPREFIX}/man1
> - _AT_mkdir -p "${DESTDIR}${MANPREFIX}/man1"
> - _AT_sed "s/VERSION/${VERSION}/g" < tabbed.1 > "${DESTDIR}${MANPREFIX}/man1/tabbed.1"
> - _AT_chmod 644 "${DESTDIR}${MANPREFIX}/man1/tabbed.1"
> - _AT_sed "s/VERSION/${VERSION}/g" < xembed.1 > "${DESTDIR}${MANPREFIX}/man1/xembed.1"
> - _AT_chmod 644 "${DESTDIR}${MANPREFIX}/man1/xembed.1"
> + _AT_mkdir -p ${DESTDIR}${MANPREFIX}/man1
> + _AT_sed "s/VERSION/${VERSION}/g" < tabbed.1 > ${DESTDIR}${MANPREFIX}/man1/tabbed.1
> + _AT_chmod 644 ${DESTDIR}${MANPREFIX}/man1/tabbed.1
> + _AT_sed "s/VERSION/${VERSION}/g" < xembed.1 > ${DESTDIR}${MANPREFIX}/man1/xembed.1
> + _AT_chmod 644 ${DESTDIR}${MANPREFIX}/man1/xembed.1
>
> uninstall:
> _AT_echo removing executable files from ${DESTDIR}${PREFIX}/bin
> - _AT_rm -f "${DESTDIR}${PREFIX}/bin/tabbed"
> - _AT_rm -f "${DESTDIR}${PREFIX}/bin/xembed"
> + _AT_rm -f ${DESTDIR}${PREFIX}/bin/tabbed
> + _AT_rm -f ${DESTDIR}${PREFIX}/bin/xembed
> _AT_echo removing manual pages from ${DESTDIR}${MANPREFIX}/man1
> - _AT_rm -f "${DESTDIR}${MANPREFIX}/man1/tabbed.1"
> - _AT_rm -f "${DESTDIR}${MANPREFIX}/man1/xembed.1"
> + _AT_rm -f ${DESTDIR}${MANPREFIX}/man1/tabbed.1
> + _AT_rm -f ${DESTDIR}${MANPREFIX}/man1/xembed.1
>
> .PHONY: all options clean dist install uninstall
> --
> 2.31.1
>
>

Hi,

I prefer with quotes. You can still do make PREFIX=~/.local or whatever.
Otherwise you could use $HOME.

-- 
Kind regards,
Hiltjo
Received on Fri Apr 02 2021 - 11:03:05 CEST

This archive was generated by hypermail 2.3.0 : Fri Apr 02 2021 - 11:12:29 CEST