Re: [hackers] [st][patch] Mild const-correctness improvements.

From: Laslo Hunhold <dev_AT_frign.de>
Date: Thu, 6 May 2021 17:56:54 +0200

On Thu, 6 May 2021 17:48:33 +0200
Hiltjo Posthuma <hiltjo_AT_codemadness.org> wrote:

Dear Hiltjo,

> The patch looks fine. I'm not in favor of some of the const changes,
> but I think it makes sense to make function parameters like for
> xstrdup() const.
>
> I'll review and push it later.

const-correctness saved me from quite a few bugs in the past, so I
personally changed my mind about it a a few years ago.

It's always good to write down "contracts", because you can only keep
so many things in your head at the same time.

With best regards

Laslo
Received on Thu May 06 2021 - 17:56:54 CEST