Re: [hackers] [svkbd][PATCH] Fix broken key definitions in layout.en.h

From: Hiltjo Posthuma <hiltjo_AT_codemadness.org>
Date: Sat, 3 Jul 2021 11:59:26 +0200

On Fri, Jul 02, 2021 at 03:23:07PM -0400, Sebastian LaVine wrote:
> There were two problems with this file.
>
> First, there were commas missing from the definitions for XK_7, XK_0,
> XK_minus, and XK_plus. This prevented svkbd from even compiling.
>
> Secondly, XK_Return was misdefined. This resulted in an immediate
> segmentation fault upon loading the program.
> ---
> layout.en.h | 10 +++++-----
> 1 file changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/layout.en.h b/layout.en.h
> index 957a251..1e10601 100644
> --- a/layout.en.h
> +++ b/layout.en.h
> _AT_@ -6,12 +6,12 @@ static Key keys_en[] = {
> { "4","$", XK_4, 1 },
> { "5","%", XK_5, 1 },
> { "6","^", XK_6, 1 },
> - { "7","&" XK_7, 1 },
> + { "7","&", XK_7, 1 },
> { "8","*", XK_8, 1 },
> { "9","(", XK_9, 1 },
> - { "0",")" XK_0, 1 },
> - { "-","_" XK_minus, 1 },
> - { "=","+" XK_plus, 1 },
> + { "0",")", XK_0, 1 },
> + { "-","_", XK_minus, 1 },
> + { "=","+", XK_plus, 1 },
> { "‚ĆęBksp",0, XK_BackSpace, 2 },
> { 0 }, /* New row */
> { "->|",0, XK_Tab, 1 },
> _AT_@ -27,7 +27,7 @@ static Key keys_en[] = {
> { 0, 0, XK_p, 1 },
> { "[","{", XK_bracketleft, 1 },
> { "]", "}", XK_bracketright, 1 },
> - { "Return", XK_Return, 3 },
> + { "Enter", 0, XK_Return, 3 },
> { 0 }, /* New row */
> { 0, 0, XK_Caps_Lock, 2 },
> { 0, 0, XK_a, 1 },
> --
> 2.32.0
>
>

Hi,

Thanks! I've also tested the other layouts and noticed a similar issue.
This should now be fixed.

-- 
Kind regards,
Hiltjo
Received on Sat Jul 03 2021 - 11:59:26 CEST

This archive was generated by hypermail 2.3.0 : Sat Jul 03 2021 - 12:00:34 CEST