Re: [hackers] [st][PATCH] arg.h: optimize & style

From: Nikita Zlobin <nick87720z_AT_gmail.com>
Date: Sun, 4 Jul 2021 18:37:01 +0500

In Sun, 4 Jul 2021 11:55:53 +0200
Hiltjo Posthuma <hiltjo_AT_codemadness.org> wrote:

> Hi,
>
> Thanks, but I prefer the current style one.
>
> I'm not confident this patch doesn't modify any behaviour.
> For example I see the `i` variable was removed, but it is actually
> important to not modify argv as this causes issues on NetBSD and
> OpenBSD process listing (see commit
> a5a928bfc1dd049780a45e072cb4ee42de7219bf).
>
> This is just one example. Unless it fixes a bug I rather keep the
> current code.
>

One my reply, before previous, did not get to archive:
> Hm, will look closer. I did not compare original arg.h from st and
> tabbed. 20h copied this file from st, so I assued they should be
> identical.

Could it be if it included some non-english letters?
When I reply, I get template with 'In' and 'wrote' words in header at
my language, russian.
That time I forgot to replace them.
Received on Sun Jul 04 2021 - 15:37:01 CEST