[hackers] [dmenu] Improve speed of drw_text when provided with large strings || Miles Alan

From: <git_AT_suckless.org>
Date: Mon, 9 Aug 2021 18:23:53 +0200 (CEST)

commit c585e8e498ec6f9c423ab8ea07cf853ee5b05fbe
Author: Miles Alan <m_AT_milesalan.com>
AuthorDate: Sat Aug 7 21:34:35 2021 -0400
Commit: Hiltjo Posthuma <hiltjo_AT_codemadness.org>
CommitDate: Mon Aug 9 18:20:51 2021 +0200

    Improve speed of drw_text when provided with large strings
    
    Calculates len & ew in drw_font_getexts loop by incrementing instead of
    decrementing; as such avoids proportional increase in time spent in loop
    based on provided strings size.

diff --git a/drw.c b/drw.c
index 4cdbcbe..9c39086 100644
--- a/drw.c
+++ b/drw.c
_AT_@ -310,8 +310,11 @@ drw_text(Drw *drw, int x, int y, unsigned int w, unsigned int h, unsigned int lp
                 if (utf8strlen) {
                         drw_font_getexts(usedfont, utf8str, utf8strlen, &ew, NULL);
                         /* shorten text if necessary */
- for (len = MIN(utf8strlen, sizeof(buf) - 1); len && ew > w; len--)
- drw_font_getexts(usedfont, utf8str, len, &ew, NULL);
+ if (ew > w)
+ for (ew = 0, len = 0; ew < w - lpad * 2 && len < MIN(utf8strlen, sizeof(buf) - 1); len++)
+ drw_font_getexts(usedfont, utf8str, len, &ew, NULL);
+ else
+ len = MIN(utf8strlen, sizeof(buf) - 1);
 
                         if (len) {
                                 memcpy(buf, utf8str, len);
Received on Mon Aug 09 2021 - 18:23:53 CEST