Re: [hackers] [dmenu][PATCH] turn -b into a toggle

From: Laslo Hunhold <>
Date: Mon, 16 Aug 2021 09:42:32 +0200

On Sun, 15 Aug 2021 23:44:58 +0600
NRK <> wrote:

Dear NRK,

> currently config.h allows users to set the value of topbar to 0.
> however if one does that, there's no way for him to get a topbar
> again. it makes more sense to have -b as a toggle instead.

this trades one problem for another given dmenu suddenly changes
behaviour unexpectedly.

Imagine someone having set up dmenu to be at the top by default (using
config.h), but having a certain launcher script that invokes dmenu to
be at the bottom by passing "-b". Now said user, using the launcher
script often, learns to prefer the bottom bar and sets it as such in
config.h. Assuming the b-flag will just be a redundancy, he keeps them
in his launcher, only to be surprised that dmenu suddenly shows up at
the top.

In my opinion, and the maintainer's may differ in that regard,
behaviour of flags should not be surprising when the defaults have been

Because of that, why not add another flag "-t" that forces dmenu to
appear at the top of the screen. This makes it immediately obvious what
happens (rather than turning b into a position-toggle, which makes zero
phonetic sense and effectively renders the b-flag unusable for scripts
because its inconsistent) and adds very little overhead.

See the attached patch (also _AT_Hiltjo, what do you think?). :)

With best regards


Received on Mon Aug 16 2021 - 09:42:32 CEST

This archive was generated by hypermail 2.3.0 : Mon Aug 16 2021 - 09:48:33 CEST