Re: [hackers] [sbase][PATCH] flock: call exec without forking

From: Arthur Williams <taaparthur_AT_disroot.org>
Date: Sun, 6 Mar 2022 13:26:30 -0800

On Sun, Mar 06, 2022 at 09:00:25PM +0100, Quentin Rameau wrote:
> > Don't believe the '-F' flag is portable so avoided trying to add
> > it.
>
> flock(1) itself isn't portable, so none of its flag are.
>

Yeah I noticed that it wasn't defined in POSIX (which makes me wounder
why it is here in sbase and not ubase). To clarify what I meant, there
are popular implementations that don't have the '-F' flag (like busybox)
and adding it would just encourage people to write code that didn't work
in many environments. And this may be fine if there was some benefit,
but I just don't see the any positives of forking.

But if we agree it isn't incorrect to not fork, any objection to the
patch?
Received on Sun Mar 06 2022 - 22:26:30 CET