Re: [hackers] [st][PATCH] rm unnecessary explicit zeroing

From: NRK <nrk_AT_disroot.org>
Date: Fri, 18 Mar 2022 03:16:56 +0600

On Thu, Mar 17, 2022 at 09:44:35PM +0100, Roberto E. Vargas Caballero wrote:
> I meant 256. If you want to be able to use any unsigned char as index
> in the array then you need 256 positions, from 0 to 255. The patch
> also had that wrong.
>
> Also, the comment of the patch only stayed that it was avoiding zeroing,
> it didn't say anything about trying (but failing) increase the portability
> of the code. It was a unneded modification for the target of the patch
> (as it was described in the comment of the commit).

Hi Roberto,

The previous array had 255 element, not 256. The patch didn't change
that, so all the patch does, effectively, is remove explicit zeroing;
just as the commit message describes.

But yes, you're right, you'd need 256 elements to be able to index into
an array as any unsigned char. So maybe it *should* be 256.

- NRK
Received on Thu Mar 17 2022 - 22:16:56 CET