Re: [hackers] [dmenu][PATCHes] Fix truncation issues and improve performance

From: NRK <nrk_AT_disroot.org>
Date: Wed, 23 Mar 2022 00:06:49 +0600

On Tue, Mar 22, 2022 at 06:06:30PM +0100, Stein Gunnar Bakkeby wrote:
> With the first patch the text is still allowed to bleed into the right hand
> side padding as long as it fits.
>
> I worked around that by reducing w with 2 * lpad and adding lpad to x
> before returning.

Yeah, that's what was causing the prompt to get cut off. I assume you
overlooked it last time I sent, but here's the reproduction step:

        ./dmenu < /dev/null -p text

With the `w -= lpad * 2`, the prompt will get cut off. Also given the
variable name is _l_pad, I think it's probably intentional for the text
to bleed in to the right side.

- NRK
Received on Tue Mar 22 2022 - 19:06:49 CET