Re: [hackers] [dmenu][PATCHes] Fix truncation issues and improve performance

From: Hiltjo Posthuma <>
Date: Wed, 23 Mar 2022 09:13:52 +0100

On Wed, Mar 23, 2022 at 12:26:24AM +0600, NRK wrote:
> On Tue, Mar 22, 2022 at 06:06:30PM +0100, Stein Gunnar Bakkeby wrote:
> > With the first patch the text is still allowed to bleed into the right hand
> > side padding as long as it fits.
> >
> > I worked around that by reducing w with 2 * lpad and adding lpad to x
> > before returning.
> Ahh, sorry my bad. I missed the "adding lpad to return" part.
> Yeah, that seems to stop the prompt from getting cut off, but I as I
> said given the variable name `lpad`, I guess that's probably
> intentional.
> Let's wait for someone to clarify what the intentional behavior is.
> > I was thinking that the function drw_font_getexts might get removed, it was
> > probably used for more in previous iterations.
> I made the patches with the assumption that they could/would also be
> integrated into libsl[0]. So I didn't remove anything or break the API.

Please continue working on this patch, it is appreciated.
When it mostly works it can be put into libsl and dmenu and dwm.

If possible please make the first iteration compatible with the current API.
This would make reviewing easier.

Afterwards it's no issue (although preferably not) if some API changes are

Reducing the changes would make this easier to review, as this code and also
Xft etc are finicky (as you probably can already tell :)).

> [0]:
> - NRK


Kind regards,
Received on Wed Mar 23 2022 - 09:13:52 CET

This archive was generated by hypermail 2.3.0 : Wed Mar 23 2022 - 09:24:47 CET