Re: [hackers] [libsl|dmenu][PATCH v2] Fix truncation issues and improve performance

From: NRK <nrk_AT_disroot.org>
Date: Tue, 29 Mar 2022 19:56:11 +0600

On Mon, Mar 28, 2022 at 05:57:48PM +0600, NRK wrote:
> And on the topic of ellipsis_width, we currently don't account for
> fallback font:
>
> usedfont = drw->fonts;
> drw_font_getexts(usedfont, "...", 3, &ellipsis_width, NULL);
>
> The assumption here was that every font should have '.' but if that
> turns out to be wrong, then the font width will be incorrect.

Attached a patch fixing this issue, as well as a patch guarding against
calling drw_text() with 0 width.

Think both these issues should be extremely rare, but can't hurt dealing
with them anyways.

- NRK

Received on Tue Mar 29 2022 - 15:56:11 CEST