[hackers] [dwm][PATCH] manage: Make sure c->isfixed is applied before floating checks

From: Chris Down <chris_AT_chrisdown.name>
Date: Tue, 26 Apr 2022 09:42:23 +0100

Commit 8806b6e23793 ("manage: propertynotify: Reduce cost of unused size
hints") mistakenly removed an early size hints update that's needed to
populate c->isfixed for floating checks at manage() time. This resulted
in fixed (size hint min dimensions == max dimensions) subset of windows
not floating when they should.

See https://lists.suckless.org/dev/2204/34730.html for discussion.

---
 dwm.c | 1 +
 1 file changed, 1 insertion(+)
diff --git a/dwm.c b/dwm.c
index 823bf6b..5646a5c 100644
--- a/dwm.c
+++ b/dwm.c
_AT_@ -1061,6 +1061,7 @@ manage(Window w, XWindowAttributes *wa)
 	XSetWindowBorder(dpy, w, scheme[SchemeNorm][ColBorder].pixel);
 	configure(c); /* propagates border_width, if size doesn't change */
 	updatewindowtype(c);
+	updatesizehints(c);
 	updatewmhints(c);
 	XSelectInput(dpy, w, EnterWindowMask|FocusChangeMask|PropertyChangeMask|StructureNotifyMask);
 	grabbuttons(c, 0);
-- 
2.35.2

Received on Tue Apr 26 2022 - 10:42:23 CEST