Re: [hackers] [quark][PATCH] Fix strftime error handling

From: Laslo Hunhold <dev_AT_frign.de>
Date: Sun, 10 Jul 2022 08:45:56 +0200

On Fri, 8 Jul 2022 11:12:17 -0700
robert <robertrussell.72001_AT_gmail.com> wrote:

Dear Robert,

> Unlike snprintf, strftime buffer contents are undefined when it fails,
> so make sure the buffer is null-terminated. To prevent garbage from
> being printed out, we simply set the timestamp to the empty string,
> but maybe setting it to "unknown time" or something similar would be
> better. Either way, I don't think this can fail until year 10000, so
> it's not a big deal.

nice catch, thanks! I'll merge it with the next window.

With best regards

Laslo
Received on Sun Jul 10 2022 - 08:45:56 CEST