[hackers] [dwm] Revert "do not call signal-unsafe function inside sighanlder" || Hiltjo Posthuma

From: <git_AT_suckless.org>
Date: Fri, 22 Jul 2022 09:19:10 +0200 (CEST)

commit e03248a4d5feaaacb130416be6e467a04de81f78
Author: Hiltjo Posthuma <hiltjo_AT_codemadness.org>
AuthorDate: Fri Jul 22 09:18:52 2022 +0200
Commit: Hiltjo Posthuma <hiltjo_AT_codemadness.org>
CommitDate: Fri Jul 22 09:18:52 2022 +0200

    Revert "do not call signal-unsafe function inside sighanlder"
    
    This reverts commit 6613d9f9a1a5630bab30bc2b70bdc793977073ee.
    
    Discussed on the mailinglist:
    https://lists.suckless.org/hackers/2207/18405.html

diff --git a/dwm.c b/dwm.c
index 7c0f978..b3c43ee 100644
--- a/dwm.c
+++ b/dwm.c
_AT_@ -1541,8 +1541,6 @@ setup(void)
         Atom utf8string;
 
         /* clean up any zombies immediately */
- if (signal(SIGCHLD, sigchld) == SIG_ERR)
- die("can't install SIGCHLD handler:");
         sigchld(0);
 
         /* init screen */
_AT_@ -1640,6 +1638,8 @@ showhide(Client *c)
 void
 sigchld(int unused)
 {
+ if (signal(SIGCHLD, sigchld) == SIG_ERR)
+ die("can't install SIGCHLD handler:");
         while (0 < waitpid(-1, NULL, WNOHANG));
 }
 
Received on Fri Jul 22 2022 - 09:19:10 CEST