Re: [hackers] [dwm][PATCH RESEND 0/2] Const-correctness fixes

From: Quentin Rameau <quinq_AT_fifth.space>
Date: Mon, 22 Aug 2022 12:03:01 +0200

Hi Cris,

> I originally sent these a few years ago and the reply was that
> const-correctness wasn't something cared about, but seeing other const
> changes in dwm, and purely const-correctness improvements in
> quark/st/libgrapheme, I figured maybe it's worth reevaluating and seeing
> if they are of interest now.

I think that the stance is still the same.

> These changes primarily avoid casting away const unnecessarily. They
> also make sure that we don't accidentally introduce non-const behaviour
> in future, and potentially UB.

Those don't “cast away constantness”, they are just cast.
While it could be argued that it makes sense to declare a variable
as const, it seems that modifying an already present cast for that
is more bikeshedding than bringing actual value.

To me, those are unuseful here, just my opinion.
Received on Mon Aug 22 2022 - 12:03:01 CEST