Re: [hackers] [dwm][PATCH RESEND 0/2] Const-correctness fixes

From: Quentin Rameau <quinq_AT_fifth.space>
Date: Mon, 22 Aug 2022 19:18:34 +0200

> >> >I think that the cast here is actually unnecessary, isn't it?
> >>
> >> No, because FcChar8 is unsigned, but the default signedness of char may be
> >> either way.
> >
> >And? FcNameParse will use whatever is passed
> >as a pointer to an unsigned char.
>
> With GCC 12.1.1 and our provided CFLAGS in config.mk:
>
> drw.c: In function ‘xfont_create’:
> drw.c:122:45: warning: pointer targets in passing argument 1 of ‘FcNameParse’ differ in signedness [-Wpointer-sign]
> 122 | if (!(pattern = FcNameParse(fontname))) {
> | ^~~~~~~~
> | |
> | const char *

That doesn't really answer the question.

Unless what you mean is that it's necessary to shut up your compiler,
but that warning isn't an error.
Received on Mon Aug 22 2022 - 19:18:34 CEST