Re: [hackers] [st][PATCH] Fix buffer overflow when handling composed input

From: Santtu Lakkala <inz_AT_inz.fi>
Date: Mon, 24 Oct 2022 13:10:29 +0300

On 24.10.2022 13.01, NRK wrote:> But which approach to take is the
maintainer's call, not mine.
> I've attched both fixed-size and dynamic-allocation patch (but
> simplified without goto).

The dynmaic[sic] version incorrectly passes sizeof(buf), where buf is
char *, as the size of buffer in the "happy case" leading to unnecessary
hits to the dynamic path.

-- 
Santtu

Received on Mon Oct 24 2022 - 12:10:29 CEST