Re: [hackers] Re: [dwm][PATCH] applyrules: fix potential false positive match

From: Hiltjo Posthuma <hiltjo_AT_codemadness.org>
Date: Sat, 29 Oct 2022 17:48:27 +0200

On Sat, Oct 29, 2022 at 06:43:12PM +0600, NRK wrote:
> On Sat, Oct 29, 2022 at 04:59:29PM +0600, NRK wrote:
> > - class = ch.res_class ? ch.res_class : broken;
> > - instance = ch.res_name ? ch.res_name : broken;
> > + class = ch.res_class ? ch.res_class : "";
> > + instance = ch.res_name ? ch.res_name : "";
>
> After some discussion on IRC and going through `git blame` (see commit
> 8dc9fcf) it seems like this behavior is intended (though questionable).
>
> In any case, feel free to ignore this.
>
> - NRK
>

Hi,

Thanks, I see what you mean with questionable but at the same time this works
this way since 2009. I'm not sure/don't think its a big issue.
Of course the user (developer) can change the applyrules() logic in any way
they'd like also.

Lately there have been some patches to change some behaviours of dwm and dmenu
in a subtle way. I'm a bit hesitant to change behaviours that have worked for
many years without complaints etc.

I do appreciate the feedback and especially patches though. If a patch is not
applied upstream please know I do try to read them all and consider them
carefully.

Thanks,

-- 
Kind regards,
Hiltjo
Received on Sat Oct 29 2022 - 17:48:27 CEST

This archive was generated by hypermail 2.3.0 : Sat Oct 29 2022 - 18:00:36 CEST