[hackers] [sent] remove unnecessary NULL checks and add `void` for an empty parameter list || Tom Schwindl

From: <git_AT_suckless.org>
Date: Tue, 10 Jan 2023 18:56:46 +0100 (CET)

commit 882d54c225b83c762acf5bb3967f4890c3ecef86
Author: Tom Schwindl <schwindl_AT_posteo.de>
AuthorDate: Tue Jan 10 17:39:33 2023 +0000
Commit: Hiltjo Posthuma <hiltjo_AT_codemadness.org>
CommitDate: Tue Jan 10 18:55:47 2023 +0100

    remove unnecessary NULL checks and add `void` for an empty parameter list

diff --git a/sent.c b/sent.c
index d949d71..dfadd3a 100644
--- a/sent.c
+++ b/sent.c
_AT_@ -99,12 +99,12 @@ static void load(FILE *fp);
 static void advance(const Arg *arg);
 static void quit(const Arg *arg);
 static void resize(int width, int height);
-static void run();
-static void usage();
-static void xdraw();
-static void xhints();
-static void xinit();
-static void xloadfonts();
+static void run(void);
+static void usage(void);
+static void xdraw(void);
+static void xhints(void);
+static void xinit(void);
+static void xloadfonts(void);
 
 static void bpress(XEvent *);
 static void cmessage(XEvent *);
_AT_@ -216,8 +216,7 @@ ffload(Slide *s)
         s->img->bufwidth = ntohl(*(uint32_t *)&hdr[8]);
         s->img->bufheight = ntohl(*(uint32_t *)&hdr[12]);
 
- if (s->img->buf)
- free(s->img->buf);
+ free(s->img->buf);
         /* internally the image is stored in 888 format */
         s->img->buf = ecalloc(s->img->bufwidth * s->img->bufheight, strlen("888"));
 
_AT_@ -499,7 +498,7 @@ resize(int width, int height)
 }
 
 void
-run()
+run(void)
 {
         XEvent ev;
 
_AT_@ -521,7 +520,7 @@ run()
 }
 
 void
-xdraw()
+xdraw(void)
 {
         unsigned int height, width, i;
         Image *im = slides[idx].img;
_AT_@ -549,7 +548,7 @@ xdraw()
 }
 
 void
-xhints()
+xhints(void)
 {
         XClassHint class = {.res_name = "sent", .res_class = "presenter"};
         XWMHints wm = {.flags = InputHint, .input = True};
_AT_@ -567,7 +566,7 @@ xhints()
 }
 
 void
-xinit()
+xinit(void)
 {
         XTextProperty prop;
         unsigned int i;
_AT_@ -611,7 +610,7 @@ xinit()
 }
 
 void
-xloadfonts()
+xloadfonts(void)
 {
         int i, j;
         char *fstrs[LEN(fontfallbacks)];
_AT_@ -630,8 +629,7 @@ xloadfonts()
         }
 
         for (j = 0; j < LEN(fontfallbacks); j++)
- if (fstrs[j])
- free(fstrs[j]);
+ free(fstrs[j]);
 }
 
 void
_AT_@ -680,7 +678,7 @@ configure(XEvent *e)
 }
 
 void
-usage()
+usage(void)
 {
         die("usage: %s [file]", argv0);
 }
Received on Tue Jan 10 2023 - 18:56:46 CET