Re: [hackers] Re: [dwm][PATCH v2] Use sigaction(SA_NOCLDWAIT) for SIGCHLD handling

From: NRK <nrk_AT_disroot.org>
Date: Sat, 28 Jan 2023 18:20:22 +0600

On Sat, Jan 28, 2023 at 12:53:48PM +0100, Hiltjo Posthuma wrote:
> waitpid() and sigaction() can also fail with EINTR, which may mean our zombie
> handling fails, so block signals while setting things up to be careful.

IMO this line should be removed from the commit message because:

* It's not accurate (afaik) becasuse EINTR isn't specified for `sigaction`:
  https://www.man7.org/linux/man-pages/man3/sigaction.3p.html#ERRORS
* the signal blocking got removed from the final patch anyways.

But otherwise it's looking OK to me :)

- NRK
Received on Sat Jan 28 2023 - 13:20:22 CET

This archive was generated by hypermail 2.3.0 : Sat Jan 28 2023 - 13:24:30 CET