[hackers] [ubase][PATCH] Explicitly include sys/sysmacros.h for makedev etc

From: Markus Rudy <webmaster_AT_burgerdev.de>
Date: Sun, 6 Aug 2023 15:03:21 +0200

This header used to be included by sys/types.h in glibc, and musl
adopted the behaviour. However, this dependency was never desired, so
glibc deprecated it in 2016 and finally removed it in 2019, and so did
musl. Explicitly including the header should be a no-op on older libc
versions and fixes the build on newer versions.

https://sourceware.org/bugzilla/show_bug.cgi?id=19239
https://git.musl-libc.org/cgit/musl/commit/?id=f552c79

---
 libutil/tty.c | 1 +
 mknod.c       | 1 +
 mountpoint.c  | 1 +
 stat.c        | 1 +
 4 files changed, 4 insertions(+)
diff --git a/libutil/tty.c b/libutil/tty.c
index bceb01e..3cb3b70 100644
--- a/libutil/tty.c
+++ b/libutil/tty.c
_AT_@ -1,4 +1,5 @@
 /* See LICENSE file for copyright and license details. */
+#include <sys/sysmacros.h>
 #include <sys/types.h>
 #include <sys/stat.h>
 
diff --git a/mknod.c b/mknod.c
index 8de35c7..518ecb0 100644
--- a/mknod.c
+++ b/mknod.c
_AT_@ -1,5 +1,6 @@
 /* See LICENSE file for copyright and license details. */
 #include <sys/stat.h>
+#include <sys/sysmacros.h>
 #include <sys/types.h>
 
 #include <fcntl.h>
diff --git a/mountpoint.c b/mountpoint.c
index 8f205a2..9a31bbe 100644
--- a/mountpoint.c
+++ b/mountpoint.c
_AT_@ -1,5 +1,6 @@
 /* See LICENSE file for copyright and license details. */
 #include <sys/stat.h>
+#include <sys/sysmacros.h>
 #include <sys/types.h>
 
 #include <mntent.h>
diff --git a/stat.c b/stat.c
index 220a659..9e96d80 100644
--- a/stat.c
+++ b/stat.c
_AT_@ -1,5 +1,6 @@
 /* See LICENSE file for copyright and license details. */
 #include <sys/stat.h>
+#include <sys/sysmacros.h>
 #include <sys/types.h>
 
 #include <inttypes.h>
-- 
2.41.0

Received on Sun Aug 06 2023 - 15:03:21 CEST