[hackers] [sbase] sbase-box: Fix segmentation fault when exe without args || Jules Maselbas

From: <git_AT_suckless.org>
Date: Thu, 28 Dec 2023 20:17:30 +0100 (CET)

commit e24228e0626e9f8ee89272f0f42d9ff9be078346
Author: Jules Maselbas <jmaselbas_AT_zdiv.net>
AuthorDate: Fri Dec 1 13:33:36 2023 +0100
Commit: Roberto E. Vargas Caballero <k0ga_AT_shike2.com>
CommitDate: Thu Dec 28 20:16:54 2023 +0100

    sbase-box: Fix segmentation fault when exe without args
    
    when sbase-box is executed without argument, the check sbase-box
    options doesn't verify the argument count leading to a segfault.
    
    Add a check on the argc before parsing sbase-box options (currently
    only `-i`)

diff --git a/scripts/mkbox b/scripts/mkbox
index b9e9bb0..db2bdb9 100755
--- a/scripts/mkbox
+++ b/scripts/mkbox
_AT_@ -76,7 +76,7 @@ main(int argc, char *argv[])
         char *s = basename(argv[0]);
         struct cmd *bp;
 
- if(!strcmp(s,"sbase-box")) {
+ if (!strcmp(s, "sbase-box") && argc > 1) {
                 argc--; argv++;
                 if (strcmp(argv[0], "-i") == 0) {
                         install(argv[1]);
Received on Thu Dec 28 2023 - 20:17:30 CET