On Sun, Feb 18, 2024 at 06:56:49AM -0600, Tim Culverhouse wrote:
> The handler for 'S' final character does not check for a private
> marker. This can cause a conflict with a sequence called 'XTSMGRAPHICS'
> which also has an 'S' final character, but uses the private marker '?'.
> Without checking for a private marker, st will perform a scroll up
> operation when XTSMGRAPHICS is seen, which can cause unexpected display
> artifacts.
> ---
> st.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/st.c b/st.c
> index d6478f55a249..034954d0aa83 100644
> --- a/st.c
> +++ b/st.c
> _AT_@ -1728,6 +1728,7 @@ csihandle(void)
> }
> break;
> case 'S': /* SU -- Scroll <n> line up */
> + if (csiescseq.priv) break;
> DEFAULT(csiescseq.arg[0], 1);
> tscrollup(term.top, csiescseq.arg[0]);
> break;
> --
> 2.43.2
>
>
Hi Tim,
Thank you, it looks good to me.
I've pushed the patch.
Have a good day,
--
Kind regards,
Hiltjo
Received on Sun Feb 18 2024 - 16:15:50 CET