Re: [hackers] [tabbed][PATCH] Use UTF8_STRING instead of COMPOUND_TEXT

From: Hiltjo Posthuma <hiltjo_AT_codemadness.org>
Date: Sun, 19 Jan 2025 13:37:01 +0100

On Sun, Jan 19, 2025 at 03:00:37PM +0300, Mikhail Pchelin wrote:
> From e64745f33ce10bd6ed2b01ae6da9ed08e56d8594 Mon Sep 17 00:00:00 2001
> From: Mikhail Pchelin <misha_AT_FreeBSD.org>
> Date: Sun, 19 Jan 2025 14:58:29 +0300
> Subject: [PATCH] Use UTF8_STRING instead of COMPOUND_TEXT
>
> Using XCompoundTextStyle makes gnome-shell issue countless warnings in
> the message log when switching between tabs or selecting text:
>
> gnome-shell[5357]: Window manager warning: Window 0x800003 has property
> _NET_WM_NAME that was expected to have type UTF8_STRING format 8 and
> actually has type COMPOUND_TEXT format 8 n_items 0. This is most likely
> an application bug, not a window manager bug. The window has
> title="0:2:vim - "hostname" " class="tabbed" name="tabbed"
> ---
> tabbed.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tabbed.c b/tabbed.c
> index 81be5e4..e5664aa 100644
> --- a/tabbed.c
> +++ b/tabbed.c
> _AT_@ -1264,7 +1264,7 @@ xsettitle(Window w, const char *str)
> XTextProperty xtp;
>
> if (XmbTextListToTextProperty(dpy, (char **)&str, 1,
> - XCompoundTextStyle, &xtp) == Success) {
> + XUTF8StringStyle, &xtp) == Success) {
> XSetTextProperty(dpy, w, &xtp, wmatom[WMName]);
> XSetTextProperty(dpy, w, &xtp, XA_WM_NAME);
> XFree(xtp.value);
> --
> 2.45.2
>
>

Pushed, thank you!

-- 
Kind regards,
Hiltjo
Received on Sun Jan 19 2025 - 13:37:01 CET

This archive was generated by hypermail 2.3.0 : Sun Jan 19 2025 - 13:48:38 CET