Re: [hackers] [sbase][PATCH] Makefile: copy scripts/getconf.sh in dist recipe

From: Roberto E. Vargas Caballero <k0ga_AT_shike2.net>
Date: Mon, 3 Nov 2025 11:52:07 +0100

Hi,

On Thu, Aug 28, 2025 at 12:26:20PM -0300, Eduardo Santos wrote:
> Building from the tarball fails:
>
> curl --no-progress-meter https://dl.suckless.org/sbase/sbase-0.1.tar.gz \
> | tar -xz --strip-components=1 \
> && make >/dev/null
> ar: creating libutf.a
> ar: creating libutil.a
> /bin/sh: line 1: scripts/getconf.sh: No such file or directory
> make: *** [Makefile:221: getconf.h] Error 127
>
> Include the missing getconf.sh script in the tarball. Prefer two
> fork(2)s to cp rather than unnecessarily increasing the tarball's size
> by including the whole scripts directory.

Good catch! But I think we actually need the full script directory
because it contains several scripts that are required for several
targets, like for example install, uninstall and sbase-box.

If you agree, I will push the following version of the patch:

commit cb7e0163503936afe1e5ce703a00a641fe3f6747
Author: Eduardo Santos <eduardo.experimental_AT_gmail.com>
Date: Thu Aug 28 12:26:20 2025 -0300

    Makefile: copy scripts in dist recipe
    
    Building from the tarball fails:
    
        curl --no-progress-meter https://dl.suckless.org/sbase/sbase-0.1.tar.gz \
            | tar -xz --strip-components=1 \
            && make >/dev/null
        ar: creating libutf.a
        ar: creating libutil.a
        /bin/sh: line 1: scripts/getconf.sh: No such file or directory
        make: *** [Makefile:221: getconf.h] Error 127
    
    The scripts contained in the script directory are required
    for several make targets (including all, install, uninstall,
    sbase-box and maybe some others).
    
    Signed-off-by: Eduardo Santos <eduardo.experimental_AT_gmail.com>

diff --git a/Makefile b/Makefile
index 3f032ac..6596063 100644
--- a/Makefile
+++ b/Makefile
_AT_@ -254,7 +254,7 @@ sbase-box-uninstall: sbase-box proto
 
 dist: clean
         mkdir -p sbase
- cp -R LICENSE Makefile README TODO config.mk *.c *.1 *.h libutf libutil make sbase
+ cp -R LICENSE Makefile README TODO config.mk *.c *.1 *.h libutf libutil make scripts sbase
         mv sbase sbase-$(VERSION)
         tar -cf sbase-$(VERSION).tar sbase-$(VERSION)
         gzip sbase-$(VERSION).tar
Received on Mon Nov 03 2025 - 11:52:07 CET

This archive was generated by hypermail 2.3.0 : Mon Nov 03 2025 - 12:00:39 CET