Re: [wiki] [sites] Tatami Layout Patch for dwm: Adds a tatami layout to dwm, accessible through Alt+Y More details are given in the index.md || Sarthak Shah

From: Quentin Rameau <quinq_AT_fifth.space>
Date: Fri, 25 Sep 2020 11:03:31 +0200

> commit c8bb38cc7df701180260f7ea3b66f903349477c4
> Author: Sarthak Shah <shahsarthakw_AT_gmail.com>
> Date: Fri Sep 25 11:10:26 2020 +0000
>
> Tatami Layout Patch for dwm:
> Adds a tatami layout to dwm, accessible through Alt+Y
> More details are given in the index.md
>
> Changes to be committed:
> new file: dwm.suckless.org/patches/tatami/dwm-tatami-6.2.diff
> new file: dwm.suckless.org/patches/tatami/index.md

Hello Sarthak,

Thank you four having made that into a proper wiki page.

A few remarks though:

> +--- dwm/config.def.h 2020-09-24 02:14:27.545355268 -0500
> ++++ dwm-tatami/config.def.h 2020-09-24 02:46:12.041952267 -0500
>
> +-static const int resizehints = 1; /* 1 means respect size hints in tiled resizals */
> ++static const int resizehints = 0; /* 1 means respect size hints in tiled resizals */

Is that really part of the patch?
This rather looks like a personnal preference that got added by mistake.

> ++#include "tatami.c"

Please no, it'd be preferable to either integrate it directly into
dwm.c, or if you prefer to keep it separated, rather add an external
definition of your function and integrate your tatami.c in the Makefile
for linking against it.

> +Usage
> +-----
> +1. Download the patch and apply according to the [general instructions](.).
> +2. Include the `tatami.c` source file and add `tatami` to the `Layout`
> + section of your `config.h` file. Example from `config.default.h`:

And then you can get rid of point 2.
Received on Fri Sep 25 2020 - 11:03:31 CEST