Re: [wiki] [sites] Removed prompt size subtraction || fssSGJ

From: Sebastian LaVine <mail_AT_smlavine.com>
Date: Tue, 02 Nov 2021 21:44:49 -0400

On Sun Oct 31, 2021 at 8:27 PM EDT, fssSGJ wrote:
> commit c6aa6cf36f03bd854525e20e3c5a49c57a6bd458
> Author: fssSGJ <fsstweeter_AT_gmail.com>
> Date: Mon Nov 1 01:19:54 2021 +0100
>
> Removed prompt size subtraction
>
> Now the full width of the menu can be used.
> There's no point to this subtraction.
> It removed the offset in the base version.
>
> diff --git
> a/tools.suckless.org/dmenu/patches/lines-below-prompt/dmenu-linesbelowprompt-and-fullwidth-20211014.diff
> b/tools.suckless.org/dmenu/patches/lines-below-prompt/dmenu-linesbelowprompt-and-fullwidth-20211014.diff
> new file mode 100644
> index 00000000..9a58224c
> --- /dev/null
> +++
> b/tools.suckless.org/dmenu/patches/lines-below-prompt/dmenu-linesbelowprompt-and-fullwidth-20211014.diff
> _AT_@ -0,0 +1,25 @@
> +From 98e63311c4816fb3c7f5c5d00232fec3232465f3 Mon Sep 17 00:00:00 2001
> +From: Sebastian LaVine <mail_AT_smlavine.com>
> +Date: Sat, 3 Jul 2021 17:35:50 -0400
> +Subject: [PATCH] Draw lines immediately below prompt
> +
> +---
> + dmenu.c | 2 +-
> + 1 file changed, 1 insertion(+), 1 deletion(-)
> +
> +diff --git a/dmenu.c b/dmenu.c
> +index 65f25ce..5a041a6 100644
> +--- a/dmenu.c
> ++++ b/dmenu.c
> +_AT_@ -154,7 +154,7 @@ drawmenu(void)
> + if (lines > 0) {
> + /* draw vertical list */
> + for (item = curr; item != next; item = item->right)
> +- drawitem(item, x, y += bh, mw - x);
> ++ drawitem(item, x - promptw, y += bh, mw);
> + } else if (matches) {
> + /* draw horizontal list */
> + x += inputw;
> +--
> +2.32.0
> +
> diff --git
> a/tools.suckless.org/dmenu/patches/lines-below-prompt/dmenu-linesbelowprompt-change.gif
> b/tools.suckless.org/dmenu/patches/lines-below-prompt/dmenu-linesbelowprompt-change.gif
> new file mode 100644
> index 00000000..6cd3ab8c
> Binary files /dev/null and
> b/tools.suckless.org/dmenu/patches/lines-below-prompt/dmenu-linesbelowprompt-change.gif
> differ
> diff --git
> a/tools.suckless.org/dmenu/patches/lines-below-prompt/index.md
> b/tools.suckless.org/dmenu/patches/lines-below-prompt/index.md
> index e7122ff6..07170a86 100644
> --- a/tools.suckless.org/dmenu/patches/lines-below-prompt/index.md
> +++ b/tools.suckless.org/dmenu/patches/lines-below-prompt/index.md
> _AT_@ -10,11 +10,18 @@ prompt.
>
> 
>
> +If you are concerned about space, you should use the 2021-11-01 patch,
> as it removes the subtraction of the prompt size.
> +
> +
> +
> +
> Download
> --------
> *
> [dmenu-linesbelowprompt-20210703-1a13d04.diff](dmenu-linesbelowprompt-20210703-1a13d04.diff)
> (2021-07-03)
> +*
> [dmenu-linesbelowprompt-and-fullwidth-20211014.diff](dmenu-linesbelowprompt-and-fullwidth-20211014.diff)
> (2021-11-01)
> +
>
> Authors
> -------
> * Sebastian LaVine <mail_AT_smlavine.com>
> -
> +* fssSGJ <fssSGJ_AT_mail.ch> (2021-11-01)

This seems to be purely a bug fix. Given this patch, I can't imagine
why anyone would want to use my old version. I think it would be better
to add it as an updated version with the same name than do it this way.
Received on Wed Nov 03 2021 - 02:44:49 CET