Re: [dev] [dwm] NetActiveWindow

From: Anselm R Garbe <>
Date: Fri, 15 Apr 2011 08:07:46 +0000

On Fri, Apr 15, 2011 at 01:31:39AM +0200, Andreas Amann wrote:
> On Thu, Apr 14, 2011 at 07:21:57PM +0200, Anselm R Garbe wrote:
> > I still don't like the fact to call view() with some Arg from within
> > dwm, will need to improve this. Arg arguments were only intended for
> > config.h, but I think we can improve this.
> Maybe the patch below is useful for this?

I think the approach has a multi-monitor flaw.

The code should rather do:

        if(!ISVISIBLE(c)) {
                c->mon->seltags ^= 1;
                c->mon->tagset[c->mon->seltags] = c->tags;

The focus(c) will update selmon propely, so that this should be fine.

Also, when looking at the above lines and zoom(), we could probably save some
compressing it into a separate function:

static void
pop(Client *c) {

Though will think about this.

Received on Fri Apr 15 2011 - 10:07:46 CEST

This archive was generated by hypermail 2.2.0 : Fri Apr 15 2011 - 10:24:03 CEST