Re: [dev] Patch for dmenu_path - pass -maxdepth 1 to find(1)

From: Troels Henriksen <athas_AT_sigkill.dk>
Date: Mon, 06 Jun 2011 23:35:06 +0200

Connor Lane Smith <cls_AT_lubutu.com> writes:

> Hey,
>
> On 6 June 2011 22:10, Troels Henriksen <athas_AT_sigkill.dk> wrote:
>> If . is part of your PATH (leaving aside questions of whether this is a
>> good idea), dmenu_path can be very slow, as it searches the entire tree
>> from the working directory for binaries, despite the fact that only
>> those immediately in the directory matter.  The following patch passes
>> -maxdepth 1 to the find(1) invocations, such that the search is no
>> deeper than actually needed to reflect the state of the PATH.
>
> Unfortunately the -maxdepth is unportable, so it isn't a possible
> solution for mainline. It is a problem though, although . in $PATH
> *is* completely broken. A solution, I suppose, could be to bundle
> lsx(1) and patch dmenu_path accordingly... Not sure how I feel about
> that. But does lsx even have a repo of its own?

You can use -prume to simulate -maxdepth 1.

-- 
\  Troels
/\ Henriksen
Received on Mon Jun 06 2011 - 23:35:06 CEST

This archive was generated by hypermail 2.2.0 : Mon Jun 06 2011 - 23:36:06 CEST