Re: [dev] [PATCH] Move default rows, cols to config.def.h

From: Alexander S. <alex0player_AT_gmail.com>
Date: Fri, 4 Jul 2014 15:23:23 +0400

2014-06-25 21:00 GMT+04:00 Roberto E. Vargas Caballero <k0ga_AT_shike2.com>:
>> > is this really necessary? Default constants don't really mean
>> > anything, they persist literally until the window is mapped and the
>> > text buffer is resized at
>> (apologies for accidentally sending)
>> L3726, so if anything, I'd vote for their removal, not their
>> canonicalization through config.[def.]h.
>
> In this case I don't agree with you guys. The size 80x24 is a very standard
> size and I don't understand why the user could want another default size.
> Remember that the user can pass parameters to st to select the initial
> size of the terminal.
> In my case 80 and 24 are more meaningful that if you use a symbolic name
> (for example default_cols or default_rows), because they are values
> that directly indicate me they are related to the default number of
> columns and rows.
I agree that symbolic constants would be odd to use, but the oint I'm
trying to make is that
those numbers specifically don't mean anything. They are replaced
before subprocess is
started, right after the X window is mapped.
Received on Fri Jul 04 2014 - 13:23:23 CEST