Re: [dev] [vis] [PATCH] Set tabwidth and expandtab in config.def.h

From: Silvan Jegen <s.jegen_AT_gmail.com>
Date: Sun, 4 Jan 2015 17:55:24 +0100

On Sun, Jan 04, 2015 at 04:37:06PM +0000, Dimitris Papastamos wrote:
> > -Editor *editor_new(int width, int height) {
> > +Editor *editor_new(int width, int height, int tabwidth, bool expandtab) {
>
> I am not affiliated with vis or have any familiarity with it
> but this doesn't make sense. I'd expect tabwidth/expandtab to be global
> variables in this case as they affect global state.
>
> This approach quickly doesn't scale if you want more parameters to
> be configured by the user and skews the semantics of the function.

I agree that this approach does not scale.

A more scalable approach may be to add tabwidth/expandtab fields to
the Config struct in vis.c and use them to initialize the Editor fields
(through the 'config' global set in main). This approach would probably
require more changes however.
Received on Sun Jan 04 2015 - 17:55:24 CET