Re: [dev] [PATCH 3/3] selnormalize: check for SEL_REGULAR explicitly

From: Roberto E. Vargas Caballero <k0ga_AT_shike2.com>
Date: Mon, 4 May 2015 11:22:20 +0200

> - if (sel.type == SEL_RECTANGULAR)
> - return;
...

> + if(sel.type == SEL_REGULAR) {
> + int len = tlinelen(sel.nb.y);

This patch inverts the logic. In the current code the function returns
when sel.type == SEL_RECTANGULAR, but in your code it test len only
when sel.type == SEL_RECTANGULAR. And I also prefer the return version,
because it requires less indentation.
Received on Mon May 04 2015 - 11:22:20 CEST