Re: [dev] [vis][RFC][PATCH 2/2] Implement the execution of external commands and cmd_substitute

From: Marc André Tanner <>
Date: Mon, 18 May 2015 22:28:06 +0200

On Mon, May 18, 2015 at 09:31:22PM +0200, Silvan Jegen wrote:
> On Sun, May 17, 2015 at 01:18:26PM +0200, Marc André Tanner wrote:
> > I have commited a couple of patches which should implement this
> > functionality as described in another mail (i.e. without allocating
> > a temporary buffer).
> I like the use of do-while/select! It reminds me of the for/select
> construct often used to select from channels in Go and I did not think
> of using C's select in that way.

Yes the current approach is rather simple. However in the long term
it would be nice to integrate these (possibly long running) tasks
into a "core" mainloop which also handles keyboard events etc.
> > Unfortunately they are only minimaly tested (I should really spend
> > my time on some university related projects).
> I did some light testing and the only issue I could find is that the
> undo-function is behaving strangely.

Yes I noticed this too. At some point while writing the patches I also
managed to trigger a segfault when redoing stuff. Might be a more
general problem although in general the editor seemed rather stable
during daily usage ...

The text-dump branch might be useful for debugging purposes of a small
test case. Anyway I most likely wont have time to look into it for
another couple of weeks.


 Marc André Tanner >< >< GPG key: CF7D56C0
Received on Mon May 18 2015 - 22:28:06 CEST

This archive was generated by hypermail 2.3.0 : Mon May 18 2015 - 22:36:08 CEST