[dev] [st][patch] apply hints before initial mapping (ICCCM)

From: Ingo Lohmar <ingo.lohmar_AT_posteo.net>
Date: Fri, 25 Oct 2019 22:11:13 +0200

A few months ago, I sent the patch below to hackers_AT_suckless.org, I am
still not sure if this was the right procedure.. In any case, since
there was no reaction to it, I am posting it here as well, looking for
comments.

The message and patch should explain themselves. If there is something
wrong with the procedure, or it this cannot be accepted for whatever
reason, I would appreciate a short reply.

Thanks!
Ingo

>>>>>>>> snip <<<<<<<<

For WM_CLASS this is mentioned in the ICCCM docs
https://tronche.com/gui/x/icccm/sec-4.html#s-4.1.2.5
(third sentence).

When changing the WM_CLASS from the command line, this is necessary for
window managers to pick it up before applying class-based rules.

---
 x.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/x.c b/x.c
index 6406925..bc3ad5a 100644
--- a/x.c
+++ b/x.c
_AT_@ -1154,8 +1154,8 @@ xinit(int cols, int rows)
 
 	win.mode = MODE_NUMLOCK;
 	resettitle();
-	XMapWindow(xw.dpy, xw.win);
 	xhints();
+	XMapWindow(xw.dpy, xw.win);
 	XSync(xw.dpy, False);
 
 	clock_gettime(CLOCK_MONOTONIC, &xsel.tclick1);
Received on Fri Oct 25 2019 - 22:11:13 CEST

This archive was generated by hypermail 2.3.0 : Fri Oct 25 2019 - 22:12:11 CEST