Re: [dwm] final test call

From: pancake <>
Date: Fri, 19 Oct 2007 13:04:52 +0200

I can't check it now, but yesterday and past i was unable to zoom
or change mwfact on any other layout but tile.

Uh oh...

 #define ISTILE isarrange(tile) /* || isarrange(<custom>) */

I's in config.h making it user-dependant...

I think this check is useless. because the only non-tiling layout is floating,
and the check for "istile" is something not much clean, because you can mix
floating and non-floating clients, etc.. so the check looks useless for me
and can remove 4 locs. :)

It makes the user configuration and source more bloated, and doesn't scales
well for lot of layouts. And for me modifying mwfact on floating is not
that noisy, because I would never do it (because im working with the mouse)
and if done it will be to blindly predefine a mwfact value.

The zooming functionality on floating mode is for me tha maximize func. so
i see no need to maintain the ISTILE check.

What do you think Arg?


On Fri, Oct 19, 2007 at 10:50:40AM +0200, Anselm R. Garbe wrote:
> On Fri, Oct 19, 2007 at 12:10:07PM +0200, pancake wrote:
> > Please remove all the ISTILE references before the release!
> >
> > Or non tile() layouts will not be able to zoom or change mwfact..
> How so? If someone applies a new layout patch, he also has to
> extend the ISTILE definition. That's the intention of ISTILE.
> Regards,
> --
> Anselm R. Garbe >< >< GPG key: 0D73F361
Received on Fri Oct 19 2007 - 11:23:16 UTC

This archive was generated by hypermail 2.2.0 : Sun Jul 13 2008 - 15:00:51 UTC