Re: [hackers] [dmenu][RFC][PATCH] History functionality

From: Silvan Jegen <>
Date: Wed, 9 Dec 2015 10:31:09 +0100

On Tue, Dec 8, 2015 at 8:34 PM, Silvan Jegen <> wrote:
> Heyhey
> On Thu, Dec 03, 2015 at 02:57:52AM -0800, Xarchus wrote:
>> [...]
>> - improved the history/cache parsing/de-duplication awk one-liner in
>> dmenu_path; the former 'NR==FNR' test was not enough: in case of a not
>> supplied or empty history file it attempted to remove a count followed by a
>> tab from the file names in the cache. Obviously to find such an occurrence
>> would be crazy rare, so it was quite harmless (I suppose that you don't
>> have any executables in your path of the form "count\tname", do you ?
>> Anyway, now you can :) )
>> New patch attached.
> I have tested it briefly and it works for me. I would remove all the
> checks as done in the attached version of the patch.
> If you are happy with this version we should put it on the website. The
> question is whether we should replace the current version that does not
> apply to tip or just add it as an alternate history patch.

I realized that I am not dealing with the case that the history file
does not exist already. I added a simple check for that (although I
was considering just putting in a comment saying that it has to).

I also missed the opportunity to remove file checks from the awk code.

Find a new patch containing these changes attached.

Received on Wed Dec 09 2015 - 10:31:09 CET

This archive was generated by hypermail 2.3.0 : Wed Dec 09 2015 - 10:36:11 CET